advancedxy commented on code in PR #42236:
URL: https://github.com/apache/spark/pull/42236#discussion_r1288301085
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/PlanGenerationTestSuite.scala:
##########
@@ -3233,14 +3233,15 @@ class PlanGenerationTestSuite
"connect/common/src/test/resources/protobuf-tests/common.desc"
test("from_protobuf messageClassName") {
- binary.select(pbFn.from_protobuf(fn.col("bytes"),
classOf[StorageLevel].getName))
+ binary.select(
+ pbFn.from_protobuf(fn.col("bytes"),
"org.apache.spark.sql.protobuf.protos.TestProtoObj"))
Review Comment:
> There is no other option. Spark at runtime includes unshaded Protobuf
library (2.5.x) in its class path.
Yeah, I noticed there's protobu-2.5 jar in the spark-3.4 client tar.
For Spark 3.5, do you think it's better to publishing both shading and
unshaded version of spark-protobuf jar? If both published, end customers could
choose which jar to use and we can documented it clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
