juliuszsompolski commented on code in PR #42415:
URL: https://github.com/apache/spark/pull/42415#discussion_r1288615576
##########
python/pyspark/sql/tests/connect/client/test_client.py:
##########
@@ -88,6 +88,11 @@ def test_is_closed(self):
client.close()
self.assertTrue(client.is_closed)
+ def test_channel_builder_with_session(self):
+ chan = ChannelBuilder("sc://foo/;session_id=abcd")
Review Comment:
non UUID sesion_id shouldn't work
##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -3522,6 +3522,13 @@ def test_metadata(self):
md = chan.metadata()
self.assertEqual([("param1", "120 21"), ("x-my-header", "abcd")], md)
+ def test_metadata(self):
+ chan = ChannelBuilder("sc://host/;session_id=abcdefgh")
Review Comment:
non UUID session_id shouldn't work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
