cloud-fan commented on code in PR #41554:
URL: https://github.com/apache/spark/pull/41554#discussion_r1288668540
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DeduplicateRelations.scala:
##########
@@ -220,7 +220,46 @@ object DeduplicateRelations extends Rule[LogicalPlan] {
if (attrMap.isEmpty) {
planWithNewChildren
} else {
- planWithNewChildren.rewriteAttrs(attrMap)
+ def rewriteAttrsMatchWithSubPlan[T <: Expression](
+ attrs: Seq[T],
+ attrMap: AttributeMap[Attribute],
+ planOutput: Seq[Attribute]): Seq[T] = {
Review Comment:
can you follow my suggestion and create two attribute maps for the left and
right child before calling this method? Then we don't need to have the third
parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
