Hisoka-X commented on code in PR #41554:
URL: https://github.com/apache/spark/pull/41554#discussion_r1288762488
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DeduplicateRelations.scala:
##########
@@ -220,7 +220,51 @@ object DeduplicateRelations extends Rule[LogicalPlan] {
if (attrMap.isEmpty) {
planWithNewChildren
} else {
- planWithNewChildren.rewriteAttrs(attrMap)
+ def rewriteAttrsMatchWithSubPlan(
+ attrs: Seq[Attribute],
+ attrMap: AttributeMap[Attribute],
+ planOutput: Seq[Attribute]): Seq[Attribute] = {
+ val canRewriteAttrs = attrMap.filter(a =>
planOutput.contains(a._2))
+ attrs.map(attr => canRewriteAttrs.getOrElse(attr, attr))
+ }
+
+ def rewriteOrderMatchWithSubPlan(
+ attrs: Seq[SortOrder],
+ attrMap: AttributeMap[Attribute],
+ planOutput: Seq[Attribute]): Seq[SortOrder] = {
+ val canRewriteAttrs = attrMap.filter(a =>
planOutput.contains(a._2))
+ attrs.filter(_.child.isInstanceOf[Attribute]).map(attr => {
+ if
(canRewriteAttrs.contains(attr.child.asInstanceOf[Attribute])) {
+ attr.copy(child =
canRewriteAttrs(attr.child.asInstanceOf[Attribute]))
+ } else {
+ attr
+ }
+ })
+ }
+
+ planWithNewChildren match {
+ case c: CoGroup =>
+ // SPARK-43781: CoGroup is a special case, as it has different
output attributes
+ // from its children. We need to update the output attributes
of CoGroup manually.
+ val newLeftAttr = c.leftAttr.map(attr =>
attrMap.getOrElse(attr, attr))
Review Comment:
> should the same apple to newRightAttr?
In fact it will be more safer, but I can't produce any negetive case.
> and to left/right group?
what's meaning? Sorry I don't get it. The left/right group already apply
`rewriteAttrsMatchWithSubPlan`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
