MaxGekk commented on code in PR #42398:
URL: https://github.com/apache/spark/pull/42398#discussion_r1288951240
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -884,6 +884,18 @@ private[sql] object QueryCompilationErrors extends
QueryErrorsBase with Compilat
messageParameters = Map("database" -> quoted))
}
+ def functionAndOrderExpressionMismatchError(
+ functionName: String,
+ functionExpr: Expression,
+ orderExpr: Expression): Throwable = {
+ new AnalysisException(
+ errorClass = "FUNCTION_AND_ORDER_EXPRESSION_MISMATCH_ERROR",
+ messageParameters = Map(
+ "functionName" -> functionName,
Review Comment:
If it is an id, quote it by `toSQLId`, if it is a SQL statement (or a part
of it), use `toSQLStmt`
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -921,6 +921,11 @@
],
"sqlState" : "42809"
},
+ "FUNCTION_AND_ORDER_EXPRESSION_MISMATCH_ERROR" : {
Review Comment:
All error classes are errors, the suffix `_ERROR` doesn't give any
additional info. Could you remove it, please:
```suggestion
"FUNCTION_AND_ORDER_EXPRESSION_MISMATCH" : {
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -2203,6 +2203,38 @@ class AstBuilder extends DataTypeAstBuilder with
SQLConfHelper with Logging {
}
}
+ /**
+ * Create a ListAgg expression.
+ */
+ override def visitListAgg(ctx: ListAggContext): AnyRef = {
+ val column = expression(ctx.aggEpxr)
+ val sortOrder = visitSortItem(ctx.sortItem)
+ if (!column.semanticEquals(sortOrder.child)) {
+ throw
QueryCompilationErrors.functionAndOrderExpressionMismatchError("list_agg",
column,
Review Comment:
Why `list_agg` but not `listagg`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
