dtenedor commented on code in PR #42422:
URL: https://github.com/apache/spark/pull/42422#discussion_r1290468784
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowPythonUDTFRunner.scala:
##########
@@ -34,6 +34,7 @@ class ArrowPythonUDTFRunner(
udtf: PythonUDTF,
evalType: Int,
offsets: Array[Int],
+ names: Array[Option[String]],
Review Comment:
These argNames match 1:1 with the argOffsets? Could it be a bit safer to
combine them into a helper case class (e.g. in case we want to add more
metadata to the arguments later?). Same for other places in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
