shuwang21 commented on code in PR #42357:
URL: https://github.com/apache/spark/pull/42357#discussion_r1292893433
##########
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala:
##########
@@ -666,6 +666,42 @@ class ClientSuite extends SparkFunSuite with Matchers {
assertUserClasspathUrls(cluster = true, replacementRootPath)
}
+ test("SPARK-44306: test directoriesToBePreloaded") {
+ val sparkConf = new SparkConf()
+ .set(YARN_CLIENT_STAT_CACHE_PRELOAD_PER_DIRECTORY_THRESHOLD, 3)
+ val client = createClient(sparkConf, args = Array("--jar", USER))
+ val directories = client.directoriesToBePreloaded(Seq(
+ "hdfs:/valid/a.jar",
+ "hdfs:/valid/b.jar",
+ "hdfs:/valid/c.jar",
+ "s3:/valid/a.jar",
+ "s3:/valid/b.jar",
+ "s3:/valid/c.jar",
+ "hdfs:/glob/*",
+ "hdfs:/fewer/a.jar",
+ "hdfs:/fewer/b.jar",
+ "local:/local/a.jar",
+ "local:/local/b.jar",
+ "local:/local/c.jar"))
+ assert(directories.size == 2 && directories.contains(new
URI("hdfs:/valid"))
+ && directories.contains(new URI("s3:/valid")))
Review Comment:
Maybe not needed? We checked `directories.size == 2`, and `directories`
contains and only contains `hdfs:/valid` and `s3:/valid`. If so,
`local:/local` cannot be founded in `directories`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
