cloud-fan commented on code in PR #42434:
URL: https://github.com/apache/spark/pull/42434#discussion_r1293486211
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuiteBase.scala:
##########
@@ -826,9 +826,9 @@ abstract class CastSuiteBase extends SparkFunSuite with
ExpressionEvalHelper {
val ret1 = cast(Literal.create(Map(1 -> "a", 2 -> "b", 3 -> "c")),
StringType)
checkEvaluation(ret1, s"${lb}1 -> a, 2 -> b, 3 -> c$rb")
val ret2 = cast(
- Literal.create(Map("1" -> "a".getBytes, "2" -> null, "3" ->
"c".getBytes)),
+ Literal.create(Map("1" -> null, "2" -> "a".getBytes, "3" ->
"c".getBytes)),
Review Comment:
can we also have a null value in the middle? so that we can have test
coverage for null in different positions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
