allisonwang-db commented on code in PR #42490:
URL: https://github.com/apache/spark/pull/42490#discussion_r1293939453
##########
python/pyspark/sql/tests/test_udtf.py:
##########
@@ -1874,15 +1874,85 @@ def eval(self, **kwargs):
for i, df in enumerate(
[
- self.spark.sql("SELECT * FROM test_udtf(a=>10, b=>'x')"),
- self.spark.sql("SELECT * FROM test_udtf(b=>'x', a=>10)"),
+ self.spark.sql("SELECT * FROM test_udtf(a => 10, b => 'x')"),
+ self.spark.sql("SELECT * FROM test_udtf(b => 'x', a => 10)"),
TestUDTF(a=lit(10), b=lit("x")),
TestUDTF(b=lit("x"), a=lit(10)),
]
):
with self.subTest(query_no=i):
assertDataFrameEqual(df, [Row(a=10, b="x")])
+ def test_udtf_with_named_arguments_lateral_join(self):
+ @udtf
+ class TestUDTF:
+ @staticmethod
+ def analyze(a, b):
+ return AnalyzeResult(StructType().add("a", a.data_type))
+
+ def eval(self, a, b):
+ yield a,
+
+ self.spark.udtf.register("test_udtf", TestUDTF)
+
+ # lateral join
+ for i, df in enumerate(
+ [
+ self.spark.sql(
+ "SELECT f.* FROM "
+ "VALUES (0, 'x'), (1, 'y') t(a, b), LATERAL test_udtf(a =>
a, b => b) f"
+ ),
+ self.spark.sql(
+ "SELECT f.* FROM "
+ "VALUES (0, 'x'), (1, 'y') t(a, b), LATERAL test_udtf(b =>
b, a => a) f"
+ ),
+ ]
+ ):
+ with self.subTest(query_no=i):
+ assertDataFrameEqual(df, [Row(a=0), Row(a=1)])
+
+ def test_udtf_with_named_arguments_and_defaults(self):
+ @udtf
+ class TestUDTF:
+ @staticmethod
+ def analyze(a, b=None):
Review Comment:
If `b` is a parameter with a default value (e.g 100), do we need to also
assign a default value (e.g. None) here in the `analyze` method? If we directly
use `def analyze(a, b)` does it throw an exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
