panbingkun commented on PR #42428:
URL: https://github.com/apache/spark/pull/42428#issuecomment-1678363142

   > @panbingkun The latest screenshot looks good! I am wondering if we should 
1) remove the `preview` docs from the version dropdown and 2) make it by 
default point to the latest **released** docs?
   
   1.Okay
   2.When we release a new version and generate pyspark docs, the 'release' 
value will be set to `RELEASE_VERSION`, 
   
https://github.com/apache/spark/blob/46580ab4cb02390ba71dace1235015749f048fff/python/docs/source/conf.py#L121-L128
   and the default value for dropbox has also been set to 'release' as shown:
   <img width="1062" alt="image" 
src="https://github.com/apache/spark/assets/15246973/c5bd19b5-5ea4-40af-8bcf-cd5820d0e88b";>
   
https://github.com/apache/spark/pull/42428/files#diff-0711e6775ff3eb4e0fb47fc40afecfe946211842573dae2c5eb872bbe53df45fR2-R5
   
   In the test below when I set `RELEASE_VERSION` to `3.4.1`, the page will 
look like this:
   <img width="1425" alt="image" 
src="https://github.com/apache/spark/assets/15246973/4b8583b6-89fd-4fec-ad46-d19e5182136d";>
   Do we need to set its default value to `latest`?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to