Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6377#discussion_r30943538
--- Diff:
core/src/test/scala/org/apache/spark/status/api/v1/SimpleDateParamTest.scala ---
@@ -21,6 +21,11 @@ import org.scalatest.{Matchers, FunSuite}
class SimpleDateParamTest extends FunSuite with Matchers {
test("date parsing") {
+ import java.util.{Locale, TimeZone}
--- End diff --
Nit: why import these so locally?
I'm slightly afraid this will have negative effects on other tests since
you're setting the defaults globally for the JVM.
Why would this fail though if the date parameter specifies its time zone?
it should not be ambiguous.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
