cloud-fan commented on code in PR #42481:
URL: https://github.com/apache/spark/pull/42481#discussion_r1294161922
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala:
##########
@@ -65,7 +65,8 @@ object SQLExecution {
*/
def withNewExecutionId[T](
queryExecution: QueryExecution,
- name: Option[String] = None)(body: => T): T =
queryExecution.sparkSession.withActive {
+ name: Option[String] = None,
+ error: Option[Throwable] = None)(body: => T): T =
queryExecution.sparkSession.withActive {
Review Comment:
OK, then shall we update the `finally` branch to send the start event as
well if it was not sent before? I feel it's awkward to ask the caller side to
indicate if it will fail the analysis or not. `def withNewExecutionId` should
be smarter about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
