dongjoon-hyun commented on PR #42484: URL: https://github.com/apache/spark/pull/42484#issuecomment-1679303774
Hi, @yaooqinn and all. This PR seems to be a partial work. According to the code, it seems to be supposed to replace ID and PASSWD, but this doesn't work correctly in two places. 1. This fails at the last update stage because the rest of code requires JIRA_USERNAME **and** JIRA_PASSWORD still. ``` Would you like to pick afe18868 into another branch? (y/n): n JIRA_USERNAME and JIRA_PASSWORD not set Exiting without trying to close the associated JIRA. ``` 2. This shows improper warning at the initial stage. ``` $ dev/merge_spark_pr.py git rev-parse --abbrev-ref HEAD The env-vars JIRA_USERNAME and/or JIRA_PASSWORD are not set. Continue? (y/n): y Which pull request would you like to merge? (e.g. 34): ``` Could you double-check and make a follow-up? FYI, I test this in the AS-IS `master` branch by unsetting both JIRA_USERNAME and JIRA_PASSWORD completely and using JIRA_ACCESS_TOKEN only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
