rangadi commented on code in PR #42283:
URL: https://github.com/apache/spark/pull/42283#discussion_r1295431536
##########
python/pyspark/sql/tests/connect/streaming/test_parity_listener.py:
##########
@@ -76,6 +80,9 @@ def test_listener_events(self):
finally:
self.spark.streams.removeListener(test_listener)
+ # Remove again to verify this won't throw any error
+ self.spark.streams.removeListener(test_listener)
Review Comment:
How does this test ensure listener worker is removed?
Another PR #42385 broke `stop()` method, but it didn't cause any failure.
(I added a comment about the breaking change:
https://github.com/apache/spark/pull/42385/files#r1295429496)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
