juliuszsompolski commented on PR #42501: URL: https://github.com/apache/spark/pull/42501#issuecomment-1681342883
@LuciferYang see https://github.com/apache/spark/pull/42523 > I need to give this a bit more thought to fully grasp the benefits of this approach. At first blush, it seems off to me to place code that's only used in the client into the common module, even though it's also used by the server module during testing. > If the goal is merely to avoid adding another module, should we consider renaming the common module to more accurately reflect its purpose? The feedback that I got was to avoid making bigger changes to module structure at this point, and that we may revisit it for 4.0. Pulling this code into server module should not hurt, as it stays benign there. Now, not trying to pull tests together, minimizes this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
