attilapiros commented on code in PR #42392:
URL: https://github.com/apache/spark/pull/42392#discussion_r1296614626
##########
python/pyspark/pandas/tests/test_resample.py:
##########
@@ -252,14 +254,32 @@ def test_dataframe_resample(self):
self._test_resample(self.pdf5, self.psdf5, ["55MIN", "2H", "D"],
"left", "left", "std")
self._test_resample(self.pdf6, self.psdf6, ["29S", "10MIN", "3H"],
"left", "right", "var")
- def test_series_resample(self):
+ def check_series_resample(self):
self._test_resample(self.pdf1.A, self.psdf1.A, ["4Y"], "right", None,
"min")
self._test_resample(self.pdf2.A, self.psdf2.A, ["13M"], "right",
"left", "max")
self._test_resample(self.pdf3.A, self.psdf3.A, ["1001H"], "right",
"right", "sum")
self._test_resample(self.pdf4.A, self.psdf4.A, ["6D"], None, None,
"mean")
self._test_resample(self.pdf5.A, self.psdf5.A, ["47T"], "left",
"left", "var")
self._test_resample(self.pdf6.A, self.psdf6.A, ["111S"], "right",
"right", "std")
+ def test_series_resample(self):
+ self.check_series_resample()
Review Comment:
@HyukjinKwon this is still an issue. The old tests still are failing when
the TZ is not UTC i.e in America/New_York.
See
https://github.com/attilapiros/spark/actions/runs/5884585704/job/15960073184?pr=5
Anyway for production we have the "spark.sql.timestampType=TIMESTAMP_NTZ"
settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
