LuciferYang opened a new pull request, #42539:
URL: https://github.com/apache/spark/pull/42539

   ### What changes were proposed in this pull request?
   This PR excludes `junit-jupiter-api` from `curator-test` to avoid maven test 
wrongly using JUnit 5 for testing.
   
   ### Why are the changes needed?
   [SPARK-44792](https://issues.apache.org/jira/browse/SPARK-44792) Upgrade 
curator to 5.2.0 and `curator-test` depends on `junit-jupiter-api`, but Apache 
Spark currently does not support testing with JUnit5, so it will report the 
following error when executing
   
   ```
   build/mvn clean install -pl core -am 
-Dtest.exclude.tags=org.apache.spark.tags.ExtendedLevelDBTest
   ```
   
   ```
   [INFO] -------------------------------------------------------
   [INFO]  T E S T S
   [INFO] -------------------------------------------------------
   [ERROR] TestEngine with ID 'junit-vintage' failed to discover tests
   [INFO] 
   [INFO] Results:
   [INFO] 
   [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
   [INFO] 
   [INFO] 
------------------------------------------------------------------------
   [INFO] Reactor Summary for Spark Project Parent POM 4.0.0-SNAPSHOT:
   [INFO] 
   [INFO] Spark Project Parent POM ........................... SUCCESS [  4.631 
s]
   [INFO] Spark Project Tags ................................. SUCCESS [  9.044 
s]
   [INFO] Spark Project Local DB ............................. SUCCESS [ 12.686 
s]
   [INFO] Spark Project Common Utils ......................... SUCCESS [ 12.216 
s]
   [INFO] Spark Project Networking ........................... SUCCESS [ 54.368 
s]
   [INFO] Spark Project Shuffle Streaming Service ............ SUCCESS [ 14.355 
s]
   [INFO] Spark Project Unsafe ............................... SUCCESS [ 12.321 
s]
   [INFO] Spark Project Launcher ............................. SUCCESS [ 10.019 
s]
   [INFO] Spark Project Core ................................. FAILURE [01:06 
min]
   [INFO] 
------------------------------------------------------------------------
   [INFO] BUILD FAILURE
   [INFO] 
------------------------------------------------------------------------
   [INFO] Total time:  03:16 min
   [INFO] Finished at: 2023-08-17T23:30:36+08:00
   [INFO] 
------------------------------------------------------------------------
   [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:3.1.2:test (default-test) on 
project spark-core_2.12: 
   [ERROR] 
   [ERROR] Please refer to 
/Users/yangjie01/SourceCode/git/spark-mine-12/core/target/surefire-reports for 
the individual test results.
   [ERROR] Please refer to dump files (if any exist) [date].dump, 
[date]-jvmRun[N].dump and [date].dumpstream.
   [ERROR] There was an error in the forked process
   [ERROR] TestEngine with ID 'junit-vintage' failed to discover tests
   [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There 
was an error in the forked process
   [ERROR] TestEngine with ID 'junit-vintage' failed to discover tests
   [ERROR]     at 
org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:628)
   [ERROR]     at 
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:285)
   [ERROR]     at 
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:250)
   [ERROR]     at 
org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1203)
   [ERROR]     at 
org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1055)
   [ERROR]     at 
org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:871)
   [ERROR]     at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
   [ERROR]     at 
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:370)
   [ERROR]     at 
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:351)
   [ERROR]     at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:215)
   [ERROR]     at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:171)
   [ERROR]     at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:163)
   [ERROR]     at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
   [ERROR]     at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
   [ERROR]     at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
   [ERROR]     at 
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
   [ERROR]     at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:299)
   [ERROR]     at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
   [ERROR]     at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
   [ERROR]     at org.apache.maven.cli.MavenCli.execute(MavenCli.java:963)
   [ERROR]     at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:296)
   [ERROR]     at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
   [ERROR]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   [ERROR]     at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   [ERROR]     at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   [ERROR]     at java.lang.reflect.Method.invoke(Method.java:498)
   [ERROR]     at 
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
   [ERROR]     at 
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
   [ERROR]     at 
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
   [ERROR]     at 
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)
   [ERROR] 
   [ERROR] -> [Help 1]
   [ERROR] 
   [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
   [ERROR] Re-run Maven using the -X switch to enable full debug logging.
   [ERROR] 
   [ERROR] For more information about the errors and possible solutions, please 
read the following articles:
   [ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
   [ERROR] 
   [ERROR] After correcting the problems, you can resume the build with the 
command
   [ERROR]   mvn <args> -rf :spark-core_2.12
   ```
   
   So we need excludes `junit-jupiter-api` from `curator-test` to restore Maven 
testing.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   - Pass GitHub Actions
   - Manually checked  Maven test no longer has the error message described 
above with this pr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to