melihsozdinler commented on code in PR #42112:
URL: https://github.com/apache/spark/pull/42112#discussion_r1297726143
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala:
##########
@@ -573,8 +573,10 @@ object DataSourceStrategy
* @return a `Some[Filter]` if the input [[Expression]] is convertible,
otherwise a `None`.
*/
protected[sql] def translateFilter(
- predicate: Expression, supportNestedPredicatePushdown: Boolean):
Option[Filter] = {
- translateFilterWithMapping(predicate, None, supportNestedPredicatePushdown)
+ predicate: Expression,
+ supportNestedPushDown: Boolean,
+ canPartialPushDown: Boolean): Option[Filter] = {
Review Comment:
canPartialPushdown and supportNestedPushDown can have a default value as
false, so if some logic does not require these options, no need to define
variable before calling function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
