cloud-fan commented on PR #42450: URL: https://github.com/apache/spark/pull/42450#issuecomment-1683756500
Shall we remove `CodegenFallback`? I think it's not a well-designed interface. An expression can't be codegened doesn't mean all its children can't be codegened. I think `Invoke` is a better idea to implement general expressions. It should also be easy to rewrite `CodegenFallback` expressions with `RuntimeReplaceable` using `Invoke` or `StaticInvoke`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
