dtenedor commented on code in PR #42549:
URL: https://github.com/apache/spark/pull/42549#discussion_r1298755028
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala:
##########
@@ -302,6 +302,24 @@ case class CurrentUser() extends LeafExpression with
Unevaluable {
final override val nodePatterns: Seq[TreePattern] = Seq(CURRENT_LIKE)
}
+// scalastyle:off line.size.limit
+@ExpressionDescription(
+ usage = """_FUNC_() - connected user name.""",
Review Comment:
Both this comment and the existing comment for `current_user` on L289 above
could use some more information, especially now that we have both
`current_user` and `session_user` as separate functions. Even if this PR
implements both functions as the same implementation, could we at least (1) dig
into how the `current_user` function is currently implemented and describe all
the cases there, and (2) mention for this `session_user` function that this
should always refer to the identity of the invoker?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
