anishshri-db commented on PR #42504: URL: https://github.com/apache/spark/pull/42504#issuecomment-1684573981
> I'm fine with leaving the plugin code as-is until we have evidence that problems are occurring there in practice. I'd bet that the combination of "stage cancellation + task reaper + executor plugin + slow IO in executor plugin" is sufficiently rare that there's not a strong motivation to guard against edge cases there, so I'm fine erring on the side of caution by not making changes there (thereby avoiding risks of unanticipated side effects, etc). Yup agreed. > Do you mind updating the PR description to reflect the final changes? Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
