HyukjinKwon commented on code in PR #41782:
URL: https://github.com/apache/spark/pull/41782#discussion_r1299491118
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -487,6 +487,25 @@ object SQLConf {
.intConf
.createWithDefault(10000)
+ val VECTORIZED_HUGE_VECTOR_RESERVE_RATIO =
+ buildConf("spark.sql.inMemoryColumnarStorage.hugeVectorReserveRatio")
+ .doc("spark will reserve requiredCapacity * this ratio memory next time.
This is only " +
Review Comment:
Can we avoid using the name of variable such as `requiredCapacity`? Also,
it's a bit difficult to understand by reading the description here. I think you
should explain this more explicitly including the behaviour of reserving * 2 by
default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
