HyukjinKwon commented on code in PR #42475:
URL: https://github.com/apache/spark/pull/42475#discussion_r1299546504
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenEvaluatorFactory.scala:
##########
@@ -41,7 +41,7 @@ class WholeStageCodegenEvaluatorFactory(
new Iterator[InternalRow] {
override def hasNext: Boolean = {
val v = buffer.hasNext
- if (!v) durationMs += buffer.durationMs()
+ if (!v) durationMs.set(buffer.durationMs())
Review Comment:
why and how was this wrong?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenEvaluatorFactory.scala:
##########
@@ -41,7 +41,7 @@ class WholeStageCodegenEvaluatorFactory(
new Iterator[InternalRow] {
override def hasNext: Boolean = {
val v = buffer.hasNext
- if (!v) durationMs += buffer.durationMs()
+ if (!v) durationMs.set(buffer.durationMs())
Review Comment:
and how did you test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
