MaxGekk commented on code in PR #42559: URL: https://github.com/apache/spark/pull/42559#discussion_r1299682964
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/percentiles.scala: ########## @@ -49,6 +50,9 @@ abstract class PercentileBase @transient private lazy val returnPercentileArray = percentageExpression.dataType.isInstanceOf[ArrayType] + private val legacyDiscCalculation: Boolean = + SQLConf.get.getConf(SQLConf.LEGACY_PERCENTILE_DISC_CALCULATION) Review Comment: This might not work well, see: - the reasons for moving val to constructor params in https://github.com/apache/spark/pull/27658 - https://github.com/apache/spark/pull/27628#discussion_r381246285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
