yaooqinn commented on code in PR #42575:
URL: https://github.com/apache/spark/pull/42575#discussion_r1299968141
##########
core/src/main/scala/org/apache/spark/status/api/v1/api.scala:
##########
@@ -527,13 +527,53 @@ case class StackTrace(elems: Seq[String]) {
}
case class ThreadStackTrace(
- val threadId: Long,
- val threadName: String,
- val threadState: Thread.State,
- val stackTrace: StackTrace,
- val blockedByThreadId: Option[Long],
- val blockedByLock: String,
- val holdingLocks: Seq[String])
+ threadId: Long,
+ threadName: String,
+ threadState: Thread.State,
+ stackTrace: StackTrace,
+ blockedByThreadId: Option[Long],
+ blockedByLock: String,
+ @deprecated("using synchronizers and monitors instead", "4.0.0")
+ holdingLocks: Seq[String],
+ synchronizers: Seq[String],
+ monitors: Seq[String],
+ lockName: Option[String],
+ lockOwnerName: Option[String],
+ suspended: Boolean,
+ inNative: Boolean) {
+
+ /**
+ * Returns a string representation of this thread stack trace
+ * w.r.t java.lang.management.ThreadInfo(JDK 8)'s toString.
+ *
+ * TODO(Kent Yao): Considering 'daemon', 'priority' from higher JDKs
+ *
+ * TODO(Kent Yao): Also considering adding information os_prio, cpu,
elapsed, tid, nid, etc.,
+ * from the jstack tool
+ */
+ override def toString: String = {
+ val sb = new StringBuilder()
+ val basic = "\"" + threadName + "\" Id=" + threadId + " " + threadState
Review Comment:
I choose another simple way `val sb = new StringBuilder(s""""$threadName"
Id=$threadId $threadState""")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
