jchen5 commented on code in PR #42383:
URL: https://github.com/apache/spark/pull/42383#discussion_r1300501201
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/DecorrelateInnerQuery.scala:
##########
@@ -654,6 +654,25 @@ object DecorrelateInnerQuery extends PredicateHelper {
val newProject = Project(newProjectList ++ referencesToAdd,
newChild)
(newProject, joinCond, outerReferenceMap)
+ case w@Window(projectList, partitionSpec, orderSpec, child) =>
+ val outerReferences = collectOuterReferences(w.expressions)
+ assert(outerReferences.isEmpty, s"Correlated column is not allowed
in window " +
+ s"function: $w")
+ val newOuterReferences = parentOuterReferences ++ outerReferences
+ val (newChild, joinCond, outerReferenceMap) =
+ decorrelate(child, newOuterReferences, aggregated = true,
underSetOp)
+ val newProjectList = replaceOuterReferences(projectList,
outerReferenceMap)
+ val newPartitionSpec = replaceOuterReferences(partitionSpec,
outerReferenceMap)
+ val newOrderSpec = replaceOuterReferences(orderSpec,
outerReferenceMap)
+ val referencesToAdd = missingReferences(
+ newPartitionSpec.asInstanceOf[Seq[NamedExpression]],
Review Comment:
Don't we want to pass newProjectList instead of newPartitionSpec? Since
those are the outputs from the window func.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
