JoshRosen commented on code in PR #41785:
URL: https://github.com/apache/spark/pull/41785#discussion_r1302142192
##########
common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java:
##########
@@ -276,10 +277,19 @@ public void initChannel(SocketChannel ch) {
// Connect to the remote server
long preConnect = System.nanoTime();
ChannelFuture cf = bootstrap.connect(address);
- if (!cf.await(conf.connectionCreationTimeoutMs())) {
+
+ if (connCreateTimeout <= 0) {
+ cf.awaitUninterruptibly();
Review Comment:
I think this should be a plain `await()` instead of
`awaitUninterruptibly()`, since the latter might lead to uninterruptible
canceled tasks. See https://github.com/apache/spark/pull/16866 for a past fix
for a similar issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
