pan3793 commented on code in PR #42599:
URL: https://github.com/apache/spark/pull/42599#discussion_r1302355574
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala:
##########
@@ -130,8 +130,7 @@ private[hive] object IsolatedClientLoader extends Logging {
}
val hiveArtifacts = version.extraDeps ++
Seq("hive-metastore", "hive-exec", "hive-common", "hive-serde")
- .map(a => s"org.apache.hive:$a:${version.fullVersion}") ++
- Seq("com.google.guava:guava:14.0.1") ++ hadoopJarNames
+ .map(a => s"org.apache.hive:$a:${version.fullVersion}") ++
hadoopJarNames
Review Comment:
> if we remove Guava from shared classes but also changed the now-non-shared
metastore Guava version then it's the same net effect and breaks older Hive
versions.
Hmm, I don't get the idea. After we remove Guava from the shared class, then
we don't need to keep Hive and Spark using the same Guava. And we did not add
Guava to `HiveVersion#exclusions`, each Hive version should automatically pull
all transitive dependencies including Guava if necessary.
Anyway, let's simply try (a) first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
