beliefer commented on code in PR #42612:
URL: https://github.com/apache/spark/pull/42612#discussion_r1302453275
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/V2ExpressionUtils.scala:
##########
@@ -159,7 +159,7 @@ object V2ExpressionUtils extends SQLConfHelper with Logging
{
StaticInvoke(scalarFunc.getClass, scalarFunc.resultType(),
MAGIC_METHOD_NAME, arguments, inputTypes = declaredInputTypes,
propagateNull = false, returnNullable = scalarFunc.isResultNullable,
- isDeterministic = scalarFunc.isDeterministic)
+ isDeterministic = scalarFunc.isDeterministic, scalarFunction =
Some(scalarFunc))
Review Comment:
Because spark already construct the StaticInvoke by calling these methods.
e.g. `scalarFunc.getClass`, `scalarFunc.resultType()` and so on.
Please keep the same way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
