zml1206 commented on code in PR #42531:
URL: https://github.com/apache/spark/pull/42531#discussion_r1302692984
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregates.scala:
##########
@@ -42,11 +42,12 @@ object RemoveRedundantAggregates extends Rule[LogicalPlan]
with AliasHelper {
)
// We might have introduces non-deterministic grouping expression
Review Comment:
@cloud-fan Thanks. I'm sorry I didn't understand. Before this PR, it will
create a `Project` below the `Aggregate` to Pulls out nondeterministic grouping
expressions. In this PR, I keep this logic, and create a `Project` below the
`Aggregate` to Pulls out complex grouping expressions by rule
`PullOutGroupingExpressions`. I do not put the new grouping expressions back to
the `Aggregate`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
