LuciferYang commented on code in PR #42643:
URL: https://github.com/apache/spark/pull/42643#discussion_r1303807283
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/application/ReplE2ESuite.scala:
##########
@@ -51,29 +50,26 @@ class ReplE2ESuite extends RemoteSparkSession with
BeforeAndAfterEach {
}
override def beforeAll(): Unit = {
- // TODO(SPARK-44121) Remove this check condition
- if (SystemUtils.isJavaVersionAtMost(JavaVersion.JAVA_17)) {
- super.beforeAll()
- ammoniteOut = new ByteArrayOutputStream()
- testSuiteOut = new PipedOutputStream()
- // Connect the `testSuiteOut` and `ammoniteIn` pipes
- ammoniteIn = new PipedInputStream(testSuiteOut)
- errorStream = new ByteArrayOutputStream()
-
- val args = Array("--port", serverPort.toString)
- val task = new Runnable {
- override def run(): Unit = {
- ConnectRepl.doMain(
- args = args,
- semaphore = Some(semaphore),
- inputStream = ammoniteIn,
- outputStream = ammoniteOut,
- errorStream = errorStream)
- }
+ super.beforeAll()
+ ammoniteOut = new ByteArrayOutputStream()
+ testSuiteOut = new PipedOutputStream()
+ // Connect the `testSuiteOut` and `ammoniteIn` pipes
+ ammoniteIn = new PipedInputStream(testSuiteOut)
+ errorStream = new ByteArrayOutputStream()
+
+ val args = Array("--port", serverPort.toString)
+ val task = new Runnable {
+ override def run(): Unit = {
+ ConnectRepl.doMain(
+ args = args,
+ semaphore = Some(semaphore),
+ inputStream = ammoniteIn,
+ outputStream = ammoniteOut,
+ errorStream = errorStream)
}
-
- executorService.submit(task)
}
+
+ executorService.submit(task)
}
override def afterAll(): Unit = {
Review Comment:
The following code needs to be cleaned up too
https://github.com/apache/spark/blob/4f8c5ede6fae3ce86b92c2649544d8f73f6a16a8/connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/RemoteSparkSession.scala#L234-L245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
