ueshin commented on code in PR #42663:
URL: https://github.com/apache/spark/pull/42663#discussion_r1304764142
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -3021,6 +3021,13 @@ class Analyzer(override val catalogManager:
CatalogManager) extends RuleExecutor
ne
case e: Expression if e.foldable =>
e // No need to create an attribute reference if it will be
evaluated as a Literal.
+ case e: NamedArgumentExpression =>
+ // For NamedArgumentExpression, we extract the value and replace it
with
+ // an AttributeReference (with an internal column name, e.g. "_w0").
+ NamedArgumentExpression(
+ e.key,
+ extractedExprMap.getOrElseUpdate(e.canonicalized,
+ Alias(e.value, s"_w${extractedExprMap.size}")()).toAttribute)
Review Comment:
@dtenedor Does this change make sense when the named arguments are specified
to window functions?
This is trying to keep the named arguments in the window functions side;
otherwise, the named arguments will go to `Project` that will be generated here
and it can't be processed because `NamedArgumentExpression` is marked as
`Unevaluable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
