dongjoon-hyun commented on code in PR #42155:
URL: https://github.com/apache/spark/pull/42155#discussion_r1304925838
##########
core/src/main/scala/org/apache/spark/storage/BlockManagerDecommissioner.scala:
##########
@@ -207,7 +207,7 @@ private[storage] class BlockManagerDecommissioner(
logInfo("Attempting to migrate all RDD blocks")
while (!stopped && !stoppedRDD) {
// Validate if we have peers to migrate to. Otherwise, give up
migration.
- if (bm.getPeers(false).isEmpty) {
+ if (!bm.getPeers(false).exists(x => x !=
FallbackStorage.FALLBACK_BLOCK_MANAGER_ID)) {
Review Comment:
Yes, it's a possible solution if we don't want to implement a migration to
S3.
nit.
```scala
if (!bm.getPeers(false).exists(x => x !=
FallbackStorage.FALLBACK_BLOCK_MANAGER_ID)) {
if (!bm.getPeers(false).exists(_ !=
FallbackStorage.FALLBACK_BLOCK_MANAGER_ID)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
