Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5934#discussion_r30949751
--- Diff:
core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala ---
@@ -32,6 +32,36 @@ class KryoSerializerSuite extends FunSuite with
SharedSparkContext {
conf.set("spark.serializer",
"org.apache.spark.serializer.KryoSerializer")
conf.set("spark.kryo.registrator", classOf[MyRegistrator].getName)
+ test("configuration limits") {
--- End diff --
General style note: this test has a _lot_ of repetition in it; the fact
that we have four conf variables, conf1, conf2, conf3, and conf4, suggests that
this could have benefitted from an inline `def` that abstracts away the actual
configuration manipulation and KryoSerializer instantiation. Either this or
whitespace between the individual cases would make this test easier to quickly
scan through.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
