mridulm commented on PR #41808: URL: https://github.com/apache/spark/pull/41808#issuecomment-1694723367
Looking at this more, this should not be that bad an issue as I initially expected - it will lead to older SHS not seeing the newer metric, but not result in failures. `ExecutorMetrics(Map[String, Long])` constructor and `JSONProtocol.executorMetricsFromJson` , which is used in the deserialization, is resilient to unknown and undefined metrics. The only issue is, it will map to the wrong index into the array - which can be easily fixed in this PR by not inserting into the middle of the array, but append to end of the `name`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
