MaxGekk commented on code in PR #42632:
URL: https://github.com/apache/spark/pull/42632#discussion_r1307212642
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/numberFormatExpressions.scala:
##########
@@ -232,10 +242,20 @@ object ToCharacterBuilder extends ExpressionBuilder {
override def build(funcName: String, expressions: Seq[Expression]):
Expression = {
val numArgs = expressions.length
if (expressions.length == 2) {
- val inputExpr = expressions.head
+ val (inputExpr, format) = (expressions(0), expressions(1))
Review Comment:
Don't think it is the right approach to split semantically one operation:
"assign names".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
