mridulm commented on code in PR #41808:
URL: https://github.com/apache/spark/pull/41808#discussion_r1307743653
##########
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala:
##########
@@ -139,14 +143,17 @@ case object GarbageCollectionMetrics extends
ExecutorMetricType with Logging {
override private[spark] def getMetricValues(memoryManager: MemoryManager):
Array[Long] = {
val gcMetrics = new Array[Long](names.length)
val mxBeans = ManagementFactory.getGarbageCollectorMXBeans.asScala
- gcMetrics(4) = mxBeans.map(_.getCollectionTime).sum
+ gcMetrics(6) = mxBeans.map(_.getCollectionTime).sum
Review Comment:
With the name ordering change, revert this ?
##########
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala:
##########
@@ -139,14 +143,17 @@ case object GarbageCollectionMetrics extends
ExecutorMetricType with Logging {
override private[spark] def getMetricValues(memoryManager: MemoryManager):
Array[Long] = {
val gcMetrics = new Array[Long](names.length)
val mxBeans = ManagementFactory.getGarbageCollectorMXBeans.asScala
- gcMetrics(4) = mxBeans.map(_.getCollectionTime).sum
+ gcMetrics(6) = mxBeans.map(_.getCollectionTime).sum
mxBeans.foreach { mxBean =>
if (youngGenerationGarbageCollector.contains(mxBean.getName)) {
gcMetrics(0) = mxBean.getCollectionCount
gcMetrics(1) = mxBean.getCollectionTime
} else if (oldGenerationGarbageCollector.contains(mxBean.getName)) {
gcMetrics(2) = mxBean.getCollectionCount
gcMetrics(3) = mxBean.getCollectionTime
+ } else if (BUILTIN_CONCURRENT_GARBAGE_COLLECTOR.equals(mxBean.getName)) {
+ gcMetrics(4) = mxBean.getCollectionCount
+ gcMetrics(5) = mxBean.getCollectionTime
Review Comment:
4 -> 5, 5 -> 6 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
