cloud-fan commented on code in PR #42683: URL: https://github.com/apache/spark/pull/42683#discussion_r1308084318
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala: ########## @@ -53,6 +53,8 @@ import org.apache.spark.util.collection.BitSet private class MutableInt(var i: Int) // A tag of a `TreeNode`, which defines name and type +// Note: In general, developers only care about its tagging capabilities, +// so Unit should be considered first before using Boolean. Review Comment: ```suggestion // then Unit should be considered first before using Boolean. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
