HyukjinKwon commented on code in PR #42710:
URL: https://github.com/apache/spark/pull/42710#discussion_r1308085001
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/VolcanoFeatureStep.scala:
##########
@@ -46,7 +46,7 @@ private[spark] class VolcanoFeatureStep extends
KubernetesDriverCustomFeatureCon
"for executor.")
return Seq.empty
}
- val client = new DefaultVolcanoClient
+ lazy val client = new DefaultVolcanoClient
val template = kubernetesConf.getOption(POD_GROUP_TEMPLATE_FILE_KEY)
val pg = template.map(client.podGroups.load(_).item).getOrElse(new
PodGroup())
Review Comment:
Actually I think we should have better create the `DefaultVolcanoClient`
within `map` but it's really a nit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
