cloud-fan commented on code in PR #42393:
URL: https://github.com/apache/spark/pull/42393#discussion_r1308387763
##########
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala:
##########
@@ -1495,14 +1499,14 @@ class InsertSuite extends DataSourceTest with
SharedSparkSession {
sql(createTableIntCol)
sql("alter table t add column s bigint default 42")
sql("alter table t add column x bigint")
- sql("insert into t values(1)")
+ sql("insert into t(i) values(1)")
checkAnswer(spark.table("t"), Row(1, 42, null))
}
// The table has a partitioning column and a default value is injected.
withTable("t") {
sql("create table t(i boolean, s bigint) using parquet partitioned by
(i)")
sql("alter table t add column q int default 42")
- sql("insert into t partition(i='true') values(5, default)")
+ sql("insert into t partition(i='true') (s, q) values(5, default)")
Review Comment:
unnecessary change?
##########
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala:
##########
@@ -1517,7 +1521,7 @@ class InsertSuite extends DataSourceTest with
SharedSparkSession {
withTable("t") {
sql("create table t(i boolean default false) using parquet")
sql("alter table t add column s bigint default 42")
- sql("insert into t values(false, default), (default, 42)")
+ sql("insert into t(i, s) values(false, default), (default, 42)")
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
