itholic commented on code in PR #40420:
URL: https://github.com/apache/spark/pull/40420#discussion_r1310665191
##########
python/pyspark/pandas/tests/indexes/test_datetime.py:
##########
@@ -269,6 +256,10 @@ def test_map(self):
mapper_pser = pd.Series([1, 2, 3], index=pidx)
self.assert_eq(psidx.map(mapper_pser), pidx.map(mapper_pser))
+ def test_isocalendar(self):
Review Comment:
If we want to add a new test, then I think it's better to also move the
related tests from "test_properties" to here.
##########
python/pyspark/pandas/tests/indexes/test_datetime.py:
##########
@@ -101,22 +102,8 @@ def test_properties(self):
self.assert_eq(psidx.day_of_week, pidx.day_of_week)
if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
Review Comment:
Let's remove this to focus on testing for the latest pandas version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
