heyihong commented on code in PR #42377:
URL: https://github.com/apache/spark/pull/42377#discussion_r1310921357
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/utils/ErrorUtils.scala:
##########
@@ -40,7 +42,15 @@ import
org.apache.spark.sql.connect.service.SparkConnectService
import org.apache.spark.sql.internal.SQLConf
private[connect] object ErrorUtils extends Logging {
- private def allClasses(cl: Class[_]): Seq[Class[_]] = {
+ private[connect] def allThrowables(t: Throwable): List[Throwable] = {
+ if (t == null) {
+ List.empty
+ } else {
+ t :: allThrowables(t.getCause)
Review Comment:
I took a look but didn't find a proper use case. Do we actually use
suppresed throwables in Spark? If not, I think we can suppress them for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
