cloud-fan commented on code in PR #42738:
URL: https://github.com/apache/spark/pull/42738#discussion_r1311036309


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityGenerator.scala:
##########
@@ -60,6 +60,8 @@ class UnivocityGenerator(
     options.locale,
     legacyFormat = FAST_DATE_FORMAT,
     isParsing = false)
+  private lazy val nullAsQuotedEmptyString =

Review Comment:
   nit: I think this can be a val as it's very likely to hit it. It's also 
relatively cheap so the lazy val protection may has bigger overhead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to