cloud-fan commented on code in PR #42763:
URL: https://github.com/apache/spark/pull/42763#discussion_r1312966146


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala:
##########
@@ -403,11 +403,19 @@ object PreprocessTableInsertion extends 
ResolveInsertionBase {
       insert.query
     }
     val newQuery = try {
+      val byName = hasColumnList || insert.byName

Review Comment:
   this is only for v1 table, does v1 table have the same problem?



##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala:
##########
@@ -403,11 +403,19 @@ object PreprocessTableInsertion extends 
ResolveInsertionBase {
       insert.query
     }
     val newQuery = try {
+      val byName = hasColumnList || insert.byName

Review Comment:
   this is only for v1 table, does v2 table have the same problem?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to