heyihong commented on code in PR #42377:
URL: https://github.com/apache/spark/pull/42377#discussion_r1313864858


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -213,4 +205,19 @@ object Connect {
     .version("3.5.0")
     .intConf
     .createWithDefault(200)
+
+  val CONNECT_ENRICH_ERROR_ENABLED =
+    buildStaticConf("spark.connect.enrichError.enabled")
+      .doc("When true, it enriches errors with full exception messages on the 
client side.")
+      .version("4.0.0")
+      .booleanConf
+      .createWithDefault(true)
+
+  val CONNECT_SERVER_STACKTRACE_ENABLED =

Review Comment:
   Same for the performance reason (it is disabled by default)



##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -213,4 +205,19 @@ object Connect {
     .version("3.5.0")
     .intConf
     .createWithDefault(200)
+
+  val CONNECT_ENRICH_ERROR_ENABLED =

Review Comment:
   Configureable per session may be better since turning off the flag (it is 
enabled by default) can make the error handling faster (i.e. without an 
additional rpc)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to