HyukjinKwon commented on code in PR #42798:
URL: https://github.com/apache/spark/pull/42798#discussion_r1315318972
##########
python/pyspark/pandas/groupby.py:
##########
@@ -3534,7 +3534,12 @@ def _reduce_for_stat_function(
for label in psdf._internal.column_labels:
psser = psdf._psser_for(label)
input_scol = psser._dtype_op.nan_to_null(psser).spark.column
- output_scol = sfun(input_scol)
+ if sfun.__name__ == "sum" and isinstance(
+ psdf._internal.spark_type_for(label), StringType
+ ):
+ output_scol = F.concat_ws("", F.collect_list(input_scol))
Review Comment:
can we sort by natural order? we have `compute.ordered_head` config. We can
sort it by natural order, and perform `collect_list`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
