itholic commented on code in PR #42787:
URL: https://github.com/apache/spark/pull/42787#discussion_r1315337724
##########
python/pyspark/pandas/indexes/base.py:
##########
@@ -1917,18 +1917,12 @@ def append(self, other: "Index") -> "Index":
sdf_other =
other._internal.spark_frame.select(other._internal.index_spark_columns)
sdf_appended = sdf_self.union(sdf_other)
- # names should be kept when MultiIndex, but Index wouldn't keep its
name.
- if isinstance(self, MultiIndex):
- index_names = self._internal.index_names
- else:
- index_names = None
-
internal = InternalFrame(
spark_frame=sdf_appended,
index_spark_columns=[
scol_for(sdf_appended, col) for col in
self._internal.index_spark_column_names
],
- index_names=index_names,
+ index_names=None,
Review Comment:
> shouldn't we also mention this in our migration doc?
Hmm.. I didn't mention this as a behavior change since it's a bug fix, but
on second thought maybe we'd better to mention in the migration guide anyway.
Let me create a follow-up for updating the migration guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
