cloud-fan commented on code in PR #42797: URL: https://github.com/apache/spark/pull/42797#discussion_r1315476814
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala: ########## @@ -67,7 +67,8 @@ abstract class UnaryMathExpression(val f: Double => Double, name: String) override def dataType: DataType = DoubleType override def nullable: Boolean = true override def toString: String = s"$prettyName($child)" - override def prettyName: String = getTagValue(FunctionRegistry.FUNC_ALIAS).getOrElse(name) + override def prettyName: String = getTagValue(FunctionRegistry.FUNC_ALIAS). + getOrElse(name.toLowerCase(Locale.ROOT)) Review Comment: is this the only place that need to change? `LeafMathExpression` does not lower-case the name either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
