Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6390#discussion_r30953002
  
    --- Diff: 
core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala ---
    @@ -50,7 +50,13 @@ class KryoSerializer(conf: SparkConf)
       with Logging
       with Serializable {
     
    -  private val bufferSizeKb = 
conf.getSizeAsKb("spark.kryoserializer.buffer", "64k")
    +  private val bufferSize = conf.get("spark.kryoserializer.buffer", "64k")
    +  private val bufferSizeKb = _
    +  if (bufferSize.endsWith("k") || bufferSize.endsWith("kb")) {
    +    bufferSizeKb = conf.getSizeAsKb("spark.kryoserializer.buffer", "64k")
    +  } else {
    +    bufferSizeKb = conf.getSizeAsMb("spark.kryoserializer.buffer", "64k")
    --- End diff --
    
    We can't do this right since the value is not then in KB. What are you 
trying to catch here, the difference between m and mb?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to