mridulm commented on code in PR #42357:
URL: https://github.com/apache/spark/pull/42357#discussion_r1318064457
##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala:
##########
@@ -492,10 +492,8 @@ private[spark] class Client(
private[yarn] def getPreloadedStatCache(
fsLookup: URI => FileSystem = FileSystem.get(_, hadoopConf)):
HashMap[URI, FileStatus] = {
val statCache = HashMap[URI, FileStatus]()
- val jars = sparkConf.get(SPARK_JARS)
- val directoryToFiles =
jars.map(directoriesToBePreloaded).getOrElse(HashMap.empty)
-
- directoryToFiles.foreach { case (dir: URI, filesInDir: HashSet[String]) =>
+ val jars = sparkConf.get(JARS_TO_DISTRIBUTE)
Review Comment:
This does not look right - `statCache` is primarily used with jars in
[SPARK_JARS](https://github.com/apache/spark/blob/622bbf2e29262c34021cb38c4c70f8eed258999b/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala#L604C21-L604C31).
Why change this ?
##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala:
##########
@@ -492,10 +492,8 @@ private[spark] class Client(
private[yarn] def getPreloadedStatCache(
fsLookup: URI => FileSystem = FileSystem.get(_, hadoopConf)):
HashMap[URI, FileStatus] = {
val statCache = HashMap[URI, FileStatus]()
- val jars = sparkConf.get(SPARK_JARS)
- val directoryToFiles =
jars.map(directoriesToBePreloaded).getOrElse(HashMap.empty)
-
- directoryToFiles.foreach { case (dir: URI, filesInDir: HashSet[String]) =>
+ val jars = sparkConf.get(JARS_TO_DISTRIBUTE)
Review Comment:
`statCache` is primarily used with jars in
[SPARK_JARS](https://github.com/apache/spark/blob/622bbf2e29262c34021cb38c4c70f8eed258999b/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala#L604C21-L604C31).
Why change this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
